Revert "Suppress eol in functionfs setup scripts (#147)"#594
Closed
tewarid wants to merge 1 commit intoopenembedded:masterfrom
Closed
Revert "Suppress eol in functionfs setup scripts (#147)"#594tewarid wants to merge 1 commit intoopenembedded:masterfrom
tewarid wants to merge 1 commit intoopenembedded:masterfrom
Conversation
This reverts commit db5f487. Signed-off-by: Devendra Tewari <devendra.tewari@gmail.com>
kraj
reviewed
Aug 20, 2022
Contributor
kraj
left a comment
kraj
left a comment
There was a problem hiding this comment.
does this work on non toybox system e.g. with busybox ? can you check
Contributor
Author
|
doesn't work with busybox :( closing this, will resubmit later |
Contributor
Author
|
please don't integrate upstream, the problem isn't the reverted commit. #595 has the appropriate fix for the issue I am seeing. |
Contributor
It has been dropped already thanks |
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Jun 27, 2023
Changelog: ========== message_t::rebuild with string argument, like the constructor openembedded#579 Add DRAFT socket options for libzmq 4.3.2-4 openembedded#594 Add function for adding file descriptor to poller_t openembedded#595 Fix noexcept warnings openembedded#581 Disambiguation from other max functions openembedded#578 Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit db5f487.
It does not seem to be necessary any more and is impeding startup of adbd on a raspberry pi system built with clang, musl, and toybox.
Signed-off-by: Devendra Tewari devendra.tewari@gmail.com